fix(auth): preserve host-established trust during handshake#99
Merged
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an auth-handshake edge case in devframe where a connection that was already marked trusted by the host (at the transport/session layer) could be downgraded to untrusted by the mandatory anonymous:devframe:auth handshake, causing the client to incorrectly prompt for OTP.
Changes:
- Update the
anonymous:devframe:authhandler to immediately return{ isTrusted: true }when the current RPC session is already trusted. - Extend the interactive-auth test suite to cover “host pre-trust before handshake” behavior via
startHttpAndWs({ onPeerConnect }).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devframe/src/recipes/interactive-auth.ts | Preserves host-established trust by short-circuiting the interactive auth handshake when the session is already trusted. |
| packages/devframe/src/recipes/tests/interactive-auth.test.ts | Adds a regression test ensuring pre-trusted sessions remain trusted after the client handshake. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts can establish trust at the transport layer before the browser runs the mandatory
anonymous:devframe:authhandshake.Vite DevTools standalone exposes this when client authentication is disabled in build mode: the WebSocket session is marked as trusted, but the subsequent handshake attempts to verify an empty bearer token and returns
isTrusted: false. The client then displays an OTP authorization screen even though the server considers the connection trusted and does not print an OTP.Fix
Return
isTrusted: truefrom the interactive auth handshake when the current session is already trusted.This preserves trust granted by the host while keeping the existing static-token and persisted-token verification paths unchanged.